lkml.org 
[lkml]   [2022]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v3 10/12] dt-bindings: mediatek: mt8188: add audio afe document
    From
    On 09/12/2022 11:56, Trevor Wu (吳文良) wrote:
    >>> +
    >>> +patternProperties:
    >>> + "^mediatek,etdm-in[1-2]-chn-disabled$":
    >>> + $ref: /schemas/types.yaml#/definitions/uint8-array
    >>> + minItems: 1
    >>> + maxItems: 16
    >>> + description:
    >>> + By default, all data received from ETDM pins will be
    >>> outputed to
    >>> + memory. etdm in supports disable_out in direct mode(w/o
    >>> interconn).
    >>> + User can specify the channel ID which they hope dropping and
    >>> then
    >>> + the specified channel won't be seen on memory.
    >>
    >> So we know what are the IDs but it's a mystery what are the values.
    >> Especially with unique values - how any of these should case that
    >> channel "won't be seen in memory"?
    >>
    > For example,
    > FE can support 14ch, but BE(etdm) can't support 14ch(it can support
    > 16ch).
    > In the case, we can configure 16ch to etdm and make use of the property
    > to disable the last two channels.
    >
    > mediatek,etdm-in1-chn-disabled = /bits/ 8 <0xE 0xF>;

    Your description should explain that this is a list of channel IDs which
    should be disabled.

    >
    >
    >>> + uniqueItems: true
    >>> + items:
    >>> + minimum: 0
    >>> + maximum: 15
    >>> +
    >>> + "^mediatek,etdm-in[1-2]-mclk-always-on-rate-hz$":
    >>> + description: Specify etdm in mclk output rate for always on
    >>> case.
    >>
    >> How is it different than assigned-clock-rates?
    >>
    > This includes clock enabling at init stage.

    assigned-clock-rates are also at init stage. I asked what is different.

    >
    >>> +
    >>> + "^mediatek,etdm-out[1-3]-mclk-always-on-rate-hz$":
    >>> + description: Specify etdm out mclk output rate for always on
    >>> case.
    >>> +
    >>> + "^mediatek,etdm-in[1-2]-multi-pin-mode$":
    >>> + type: boolean
    >>> + description: if present, the etdm data mode is I2S.
    >>> +
    >>> + "^mediatek,etdm-out[1-3]-multi-pin-mode$":
    >>> + type: boolean
    >>> + description: if present, the etdm data mode is I2S.
    >>> +
    >>> + "^mediatek,etdm-in[1-2]-cowork-source$":
    >>> + $ref: /schemas/types.yaml#/definitions/uint32
    >>> + description:
    >>> + etdm modules can share the same external clock pin. Specify
    >>> + which etdm clock source is required by this etdm in moudule.
    >>
    >> typo: module
    >>

    Best regards,
    Krzysztof

    \
     
     \ /
      Last update: 2022-12-09 15:57    [W:4.212 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site