Messages in this thread | | | Date | Fri, 9 Dec 2022 01:04:56 -0500 | From | "Theodore Ts'o" <> | Subject | Re: [PATCH v4 3/3] ext4: add check pending tree when evict inode |
| |
On Thu, Dec 08, 2022 at 11:34:26AM +0800, Ye Bin wrote: > > Above issue fixed by > commit 1b8f787ef547 ("ext4: fix warning in 'ext4_da_release_space'") > in this scene. To make things better add check pending tree when evict > inode. > According to Eric Whitney's suggestion, bigalloc + inline is still in > development so we just add test for this situation, there isn't need to > add code to free pending tree entry.
The i_pending_tree is an in-memory data structure, and so it's not appropriate to call ext4_error(), because there will be nothing for fsck to fix.
If you really want to a bug to be noticed, you could use a ext4_msg plus a WARN_ON(); but an ext4_error() is really not appropriate.
Cheers,
- Ted
| |