Messages in this thread | | | Date | Thu, 8 Dec 2022 13:16:01 +0000 | From | Lee Jones <> | Subject | Re: [PATCH] mfd: Drop obsolete dependencies on COMPILE_TEST |
| |
On Tue, 22 Nov 2022, Jean Delvare wrote:
> Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it > is possible to test-build any driver which depends on OF on any > architecture by explicitly selecting OF. Therefore depending on > COMPILE_TEST as an alternative is no longer needed. > > It is actually better to always build such drivers with OF enabled, > so that the test builds are closer to how each driver will actually be > built on its intended target. Building them without OF may not test > much as the compiler will optimize out potentially large parts of the > code. In the worst case, this could even pop false positive warnings. > Dropping COMPILE_TEST here improves the quality of our testing and > avoids wasting time on non-existent issues. > > As a minor optimization, this also lets us drop of_match_ptr(), as we > now know what it will resolve to, we might as well save cpp some work. > > Signed-off-by: Jean Delvare <jdelvare@suse.de> > Cc: Lee Jones <lee@kernel.org> > Cc: Bartosz Golaszewski <brgl@bgdev.pl> > Cc: Chanwoo Choi <cw00.choi@samsung.com> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > Cc: Luca Ceresoli <luca.ceresoli@bootlin.com> > Cc: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net> > --- > drivers/mfd/Kconfig | 16 ++++++++-------- > drivers/mfd/motorola-cpcap.c | 2 +- > 2 files changed, 9 insertions(+), 9 deletions(-)
Applied, thanks.
-- Lee Jones [李琼斯]
| |