Messages in this thread | | | Date | Wed, 7 Dec 2022 16:33:12 +0100 | From | Jiri Pirko <> | Subject | Re: [PATCH net-next 2/2] macsec: dump IFLA_MACSEC_OFFLOAD attribute as part of macsec dump |
| |
Wed, Dec 07, 2022 at 11:10:17AM CET, ehakim@nvidia.com wrote: >From: Emeel Hakim <ehakim@nvidia.com> > >consider IFLA_MACSEC_OFFLOAD in macsec's device dump,
Sentense starts with capital letter.
>this mandates a change at macsec_get_size to consider the >additional attribute.
I'm unable to understand what you mean by this description. What should the codebase consider and why?
Code looks fine.
> >Reviewed-by: Raed Salem <raeds@nvidia.com> >Signed-off-by: Emeel Hakim <ehakim@nvidia.com> >--- > drivers/net/macsec.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > >diff --git a/drivers/net/macsec.c b/drivers/net/macsec.c >index 1850a1ee4380..0b8613576383 100644 >--- a/drivers/net/macsec.c >+++ b/drivers/net/macsec.c >@@ -4257,16 +4257,22 @@ static size_t macsec_get_size(const struct net_device *dev) > nla_total_size(1) + /* IFLA_MACSEC_SCB */ > nla_total_size(1) + /* IFLA_MACSEC_REPLAY_PROTECT */ > nla_total_size(1) + /* IFLA_MACSEC_VALIDATION */ >+ nla_total_size(1) + /* IFLA_MACSEC_OFFLOAD */ > 0; > } > > static int macsec_fill_info(struct sk_buff *skb, > const struct net_device *dev) > { >- struct macsec_secy *secy = &macsec_priv(dev)->secy; >- struct macsec_tx_sc *tx_sc = &secy->tx_sc; >+ struct macsec_tx_sc *tx_sc; >+ struct macsec_dev *macsec; >+ struct macsec_secy *secy; > u64 csid; > >+ macsec = macsec_priv(dev); >+ secy = &macsec->secy; >+ tx_sc = &secy->tx_sc; >+ > switch (secy->key_len) { > case MACSEC_GCM_AES_128_SAK_LEN: > csid = secy->xpn ? MACSEC_CIPHER_ID_GCM_AES_XPN_128 : MACSEC_DEFAULT_CIPHER_ID; >@@ -4291,6 +4297,7 @@ static int macsec_fill_info(struct sk_buff *skb, > nla_put_u8(skb, IFLA_MACSEC_SCB, tx_sc->scb) || > nla_put_u8(skb, IFLA_MACSEC_REPLAY_PROTECT, secy->replay_protect) || > nla_put_u8(skb, IFLA_MACSEC_VALIDATION, secy->validate_frames) || >+ nla_put_u8(skb, IFLA_MACSEC_OFFLOAD, macsec->offload) || > 0) > goto nla_put_failure; > >-- >2.21.3 >
| |