lkml.org 
[lkml]   [2022]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH v2 2/2] MIPS: BCM63xx: Add check for NULL for clk in clk_enable
Date
Errors from previous version of patch fixed.
Check clk for NULL before calling clk_enable_unlocked where clk
is dereferenced. There is such check in other implementations
of clk_enable.

Found by Linux Verification Center (linuxtesting.org) with SVACE.
Fixes: e7300d04bd08 ("MIPS: BCM63xx: Add support for the Broadcom BCM63xx family of SOCs.")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Anastasia Belova <abelova@astralinux.ru>
---
arch/mips/bcm63xx/clk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/bcm63xx/clk.c b/arch/mips/bcm63xx/clk.c
index 401140cf36d9..cf303d6e6693 100644
--- a/arch/mips/bcm63xx/clk.c
+++ b/arch/mips/bcm63xx/clk.c
@@ -362,7 +362,7 @@ static struct clk clk_periph = {
int clk_enable(struct clk *clk)
{
if (!clk)
- return;
+ return 0;

mutex_lock(&clocks_mutex);
clk_enable_unlocked(clk);
--
2.30.2
\
 
 \ /
  Last update: 2022-12-07 15:30    [W:0.040 / U:0.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site