lkml.org 
[lkml]   [2022]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: linux-next: Signed-off-by missing for commit in the v4l-dvb-next tree
From
On 12/6/22 21:56, Stephen Rothwell wrote:
> Hi all,
>
> Commits
>
> 85abf40b56af ("media: ipu3-cio2: make the bridge depend on i2c")
> ca61babacbe8 ("media: MAINTAINERS: Add Hans de Goede as staging/atomisp maintainer")
>
> are missing a Signed-off-by from their committer.
>

They have a SoB, but there is a 'Link:' tag right before that:

commit 85abf40b56af5f3130a4f9dcdb808c7feb64e083
Author: Adam Borowski <kilobyte@angband.pl>
Date: Fri Sep 16 00:33:18 2022 +0100

media: ipu3-cio2: make the bridge depend on i2c

drivers/media/pci/intel/ipu3/cio2-bridge.c: In function ‘cio2_bridge_unregister_sensors’:
drivers/media/pci/intel/ipu3/cio2-bridge.c:258:17: error: implicit declaration of function ‘i2c_unregister_device’; did you mean ‘spi_unregister_device’? [-Werror=implicit-function-declaration]
258 | i2c_unregister_device(sensor->vcm_i2c_client);
| ^~~~~~~~~~~~~~~~~~~~~
| spi_unregister_device

Link: https://lore.kernel.org/linux-media/S230142AbiJTWql/20221020224641Z+958@vger.kernel.org
Signed-off-by: Adam Borowski <kilobyte@angband.pl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>

commit ca61babacbe8ada7a0671f910c22b8758f481c0c
Author: Hans de Goede <hdegoede@redhat.com>
Date: Wed Nov 23 16:14:47 2022 +0000

media: MAINTAINERS: Add Hans de Goede as staging/atomisp maintainer

Add myself as maintainer for the drivers/staging/media/atomisp code.

Link: https://lore.kernel.org/linux-media/20221123161447.15834-1-hdegoede@redhat.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>

Could that be the cause? checkpatch doesn't complain about this.

Regards,

Hans

\
 
 \ /
  Last update: 2022-12-07 11:09    [W:0.077 / U:0.872 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site