lkml.org 
[lkml]   [2022]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] iio: magnetometer: hmc5843: Convert to use sysfs_emit_at() API
On Wed, Dec 7, 2022 at 9:51 AM <ye.xingchen@zte.com.cn> wrote:
>
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Follow the advice of the Documentation/filesystems/sysfs.rst and show()
> should only use sysfs_emit() or sysfs_emit_at() when formatting the
> value to be returned to user space.

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmai.com>

> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
> ---
> drivers/iio/magnetometer/hmc5843_core.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/iio/magnetometer/hmc5843_core.c b/drivers/iio/magnetometer/hmc5843_core.c
> index c5521d61da29..134f6045e24a 100644
> --- a/drivers/iio/magnetometer/hmc5843_core.c
> +++ b/drivers/iio/magnetometer/hmc5843_core.c
> @@ -274,9 +274,9 @@ ssize_t hmc5843_show_samp_freq_avail(struct device *dev,
> int i;
>
> for (i = 0; i < data->variant->n_regval_to_samp_freq; i++)
> - len += scnprintf(buf + len, PAGE_SIZE - len,
> - "%d.%d ", data->variant->regval_to_samp_freq[i][0],
> - data->variant->regval_to_samp_freq[i][1]);
> + len += sysfs_emit_at(buf, len, "%d.%d ",
> + data->variant->regval_to_samp_freq[i][0],
> + data->variant->regval_to_samp_freq[i][1]);
>
> /* replace trailing space by newline */
> buf[len - 1] = '\n';
> @@ -335,8 +335,7 @@ static ssize_t hmc5843_show_scale_avail(struct device *dev,
> int i;
>
> for (i = 0; i < data->variant->n_regval_to_nanoscale; i++)
> - len += scnprintf(buf + len, PAGE_SIZE - len,
> - "0.%09d ", data->variant->regval_to_nanoscale[i]);
> + len += sysfs_emit_at(buf, len, "0.%09d ", data->variant->regval_to_nanoscale[i]);
>
> /* replace trailing space by newline */
> buf[len - 1] = '\n';
> --
> 2.25.1



--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2022-12-07 09:50    [W:0.034 / U:1.336 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site