Messages in this thread | | | From | Prashant Malani <> | Date | Wed, 7 Dec 2022 00:02:03 -0800 | Subject | Re: [PATCH] platform/chrome: cros_ec_typec: zero out stale pointers |
| |
Hi Victor,
On Tue, Dec 6, 2022 at 8:02 PM Victor Ding <victording@chromium.org> wrote: > > `cros_typec_get_switch_handles` allocates several pointers when > obtaining four handles. These pointers are all freed if failing to > obtain any of the four handles; therefore, pointers in `port` becomes > stale. The stale pointers eventually cause use-after-free or double in > later code paths. > > This patch proposes Please use the imperative form [1]
> to elimite these stale pointers by zeroing them out
s/elimite/eliminate
> right after they are freed. > > Signed-off-by: Victor Ding <victording@chromium.org> This should have a "Fixes" tag.
Best regards,
-Prashant
[1] https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes
| |