Messages in this thread | | | Date | Wed, 7 Dec 2022 17:16:06 -0800 | From | Alexei Starovoitov <> | Subject | Re: [PATCH bpf-next v3 2/2] bpf/docs: Document struct cgroup * kfuncs |
| |
On Wed, Dec 07, 2022 at 02:49:11PM -0600, David Vernet wrote: > diff --git a/kernel/bpf/helpers.c b/kernel/bpf/helpers.c > index 1e4bf466b08f..1478862702fc 100644 > --- a/kernel/bpf/helpers.c > +++ b/kernel/bpf/helpers.c > @@ -1960,7 +1960,7 @@ struct cgroup *bpf_cgroup_kptr_get(struct cgroup **cgrpp) > } > > /** > - * bpf_cgroup_release - Release the reference acquired on a struct cgroup *. > + * bpf_cgroup_release - Release the reference acquired on a struct cgroup kptr.
While applying I've changed above to be 'on a cgroup' to match what you have in patch 1 for bpf_task_release and existing bpf_cgroup_acquire doc. bpf_cgroup_kptr_get doc stays as "on a struct cgroup kptr.". Which makes sense. Please let me know if I misunderstood the intent.
| |