Messages in this thread | | | Date | Wed, 7 Dec 2022 15:52:05 -0800 | Subject | Re: [PATCH v4 4/4] ufs: core: Remove ufshcd_map_desc_id_to_length function | From | Bart Van Assche <> |
| |
On 11/27/22 04:08, Arthur Simchaev wrote: > There shouldn't be any restriction of the descriptor size > (not the descriptor id for that matter) up to QUERY_DESC_MAX_SIZE. > According to the spec, the caller can use any descriptor size, > and it is up to the device to return the actual size. > Therefore there shouldn't be any sizes hardcoded in the kernel, > nor any need to cache it, hence ufshcd_map_desc_id_to_length function is redundant. > always read the descriptors with QUERY_DESC_MAX_SIZE size.
This patch looks good to me but I expect that it will change if my comment on patch 1/4 is addressed?
Thanks,
Bart.
| |