Messages in this thread | | | From | Linus Walleij <> | Date | Wed, 7 Dec 2022 23:52:29 +0100 | Subject | Re: [PATCH v2 2/2] pinctrl: add NXP S32 SoC family support |
| |
On Mon, Nov 28, 2022 at 6:49 AM Chester Lin <clin@suse.com> wrote:
> Add the pinctrl driver for NXP S32 SoC family. This driver is mainly based > on NXP's downstream implementation on CodeAurora[1]. > > [1] https://source.codeaurora.org/external/autobsps32/linux/tree/drivers/pinctrl/freescale?h=bsp34.0-5.10.120-rt > > Signed-off-by: Matthew Nunez <matthew.nunez@nxp.com> > Signed-off-by: Phu Luu An <phu.luuan@nxp.com> > Signed-off-by: Stefan-Gabriel Mirea <stefan-gabriel.mirea@nxp.com> > Signed-off-by: Larisa Grigore <larisa.grigore@nxp.com> > Signed-off-by: Ghennadi Procopciuc <Ghennadi.Procopciuc@nxp.com> > Signed-off-by: Andrei Stefanescu <andrei.stefanescu@nxp.com> > Signed-off-by: Radu Pirea <radu-nicolae.pirea@nxp.com> > Signed-off-by: Chester Lin <clin@suse.com> > --- > > Changes in v2: > - Create a s32_pin_range matrix in the driver for replacing the "nxp,pins" > property in DT. > - Refine the compatible name to "nxp,s32g2-siul2-pinctrl". > - Fix the copyright requested by NXP. > - Remove a few recipients from the Cc list since these email addresses are no > longer available.
Overall this version looks very good. I will be happy to merge it once Andreas comments are addressed, and it is rebased on v6.2-rc1 once that is out in some two+ weeks.
Yours, Linus Walleij
| |