Messages in this thread | | | Date | Tue, 6 Dec 2022 08:32:14 -0800 | Subject | Re: [PATCH] drm/msm/dpu: Add check for cstate | From | Abhinav Kumar <> |
| |
On 12/6/2022 12:05 AM, Jiasheng Jiang wrote: > As kzalloc may fail and return NULL pointer, > it should be better to check cstate > in order to avoid the NULL pointer dereference > in __drm_atomic_helper_crtc_reset.
You have wrapped around your lines too short. Please try to utilize the full word limit for each line.
With that fixed,
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
> > Fixes: 1cff7440a86e ("drm/msm: Convert to using __drm_atomic_helper_crtc_reset() for reset.") > Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn> > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > index 13ce321283ff..22c2787b7b38 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > @@ -968,7 +968,10 @@ static void dpu_crtc_reset(struct drm_crtc *crtc) > if (crtc->state) > dpu_crtc_destroy_state(crtc, crtc->state); > > - __drm_atomic_helper_crtc_reset(crtc, &cstate->base); > + if (cstate) > + __drm_atomic_helper_crtc_reset(crtc, &cstate->base); > + else > + __drm_atomic_helper_crtc_reset(crtc, NULL); > } > > /**
| |