lkml.org 
[lkml]   [2022]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 07/18] x86/sgx: Use a list to track to-be-reclaimed pages during reclaim
From
On 12/5/22 08:33, Kristen Carlson Accardi wrote:
> The helpers were added because Jarrko requested a queue abstraction for
> the sgx_epc_lru_lists data structure in the first round of reviews. the
> simple one line inlines are effectively just renaming to make the queue
> abstraction more obvious to the reader.

Jarkko,

Do you have any issues with zapping these helpers? I really don't think
they add to readability. The "reclaimable" versus "unreclaimable"
naming is patently obvious from the structure member names. I'm not
sure what value it adds to have them in the function names too.


\
 
 \ /
  Last update: 2022-12-05 18:04    [W:0.173 / U:1.516 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site