lkml.org 
[lkml]   [2022]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v2 4/9] mtd: nand: ecc-mtk: Add ECC support fot MT7986 IC
    From
    Il 05/12/22 07:57, Xiangsheng Hou ha scritto:
    > Add ECC support fot MT7986 IC.
    >
    > Signed-off-by: Xiangsheng Hou <xiangsheng.hou@mediatek.com>
    > ---
    > drivers/mtd/nand/ecc-mtk.c | 18 ++++++++++++++++++
    > 1 file changed, 18 insertions(+)
    >
    > diff --git a/drivers/mtd/nand/ecc-mtk.c b/drivers/mtd/nand/ecc-mtk.c
    > index 9f9b201fe706..c2f6cfa76a04 100644
    > --- a/drivers/mtd/nand/ecc-mtk.c
    > +++ b/drivers/mtd/nand/ecc-mtk.c
    > @@ -79,6 +79,10 @@ static const u8 ecc_strength_mt7622[] = {
    > 4, 6, 8, 10, 12
    > };
    >
    > +static const u8 ecc_strength_mt7986[] = {
    > + 4, 6, 8, 10, 12, 14, 16, 18, 20, 22, 24
    > +};
    > +
    > enum mtk_ecc_regs {
    > ECC_ENCPAR00,
    > ECC_ENCIRQ_EN,
    > @@ -483,6 +487,17 @@ static const struct mtk_ecc_caps mtk_ecc_caps_mt7622 = {
    > .pg_irq_sel = 0,
    > };
    >
    > +static const struct mtk_ecc_caps mtk_ecc_caps_mt7986 = {
    > + .err_mask = 0x1f,

    Can't we use GENMASK() to define err_mask instead?

    #define MT7986_ERRNUM GENMASK(4, 0)

    P.S.: Did I get that right? Is that referred to the ERRNUM(x) bits?

    Regards,
    Angelo


    \
     
     \ /
      Last update: 2022-12-05 15:22    [W:3.911 / U:0.584 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site