lkml.org 
[lkml]   [2022]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] perf stat: Fix invalid output handle
Em Sun, Dec 04, 2022 at 10:38:28PM +0530, Athira Rajeev escreveu:
>
>
> > On 01-Dec-2022, at 3:36 PM, James Clark <james.clark@arm.com> wrote:
> >
> >
> >
> > On 30/11/2022 18:32, Namhyung Kim wrote:
> >> On Wed, Nov 30, 2022 at 3:15 AM James Clark <james.clark@arm.com> wrote:
> >>>
> >>> In this context, 'os' is already a pointer so the extra dereference
> >>> isn't required. This fixes the following test failure on aarch64:
> >>>
> >>> $ ./perf test "json output" -vvv
> >>> 92: perf stat JSON output linter :
> >>> --- start ---
> >>> Checking json output: no args Test failed for input:
> >>> ...
> >>> Fatal error: glibc detected an invalid stdio handle
> >>> ---- end ----
> >>> perf stat JSON output linter: FAILED!
> >>>
> >>> Fixes: e7f4da312259 ("perf stat: Pass struct outstate to printout()")
> >>> Signed-off-by: James Clark <james.clark@arm.com>
> >>
> >> Thanks for fixing this. I'm not sure how I missed it.. :(
> >>
> >
> > It seems to only go down that path on some configuration. At least on
> > x86 the test was passing fine for me.
> >
> >> Acked-by: Namhyung Kim <namhyung@kernel.org>
> >
> > Thanks for the review!
>
> Faced same issue on powerpc. Tested with this change and it works with this patch.
>
> Tested-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com>

Thanks, applied.

- Arnaldo

\
 
 \ /
  Last update: 2022-12-05 14:08    [W:0.066 / U:3.348 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site