Messages in this thread | ![/](/images/icornerl.gif) | | Date | Mon, 5 Dec 2022 14:04:09 +0800 | Subject | Re: [PATCH v10 1/2] gpio: loongson: add gpio driver support | From | Yinbo Zhu <> |
| |
在 2022/12/3 23:41, Andy Shevchenko 写道: > On Sat, Dec 03, 2022 at 05:27:31PM +0200, Andy Shevchenko wrote: >> On Sat, Dec 03, 2022 at 06:53:20PM +0800, Yinbo Zhu wrote: >>> 在 2022/12/3 18:03, Linus Walleij 写道: >>>> On Thu, Dec 1, 2022 at 1:33 PM Yinbo Zhu <zhuyinbo@loongson.cn> wrote: >>>>> +config GPIO_LOONGSON_64BIT >>>>> + tristate "Loongson 64 bit GPIO support" >>>>> + depends on LOONGARCH || COMPILE_TEST >>>>> + select GPIO_GENERIC >>>>> + select GPIOLIB_IRQCHIP >>>> If the kernelbots start complaining you might need to add a: >>>> >>>> select IRQ_DOMAIN_HIERARCHY >>>> >>>> here. >>> Bartosz had merged my patch and I will add a change on top of the existing >>> series. >> I don;'t know why he had done that, the driver requires a lot of cleanups, >> e.g. why it uses acpi.h, what that "nice" container of the platform device for.
I just compile it that it is still okay when remove acpi.h, so I will remove it in v11.
and, I'm afraid I didn't catch your meaning about "
what that "nice" container of the platform device for."
you said is for following code ? 144 struct platform_device *pdev = 145 container_of(chip->parent, struct platform_device, dev);
> + we have macros for get_direction() returned values and so on. okay, I will use that macros in v11.
| ![\](/images/icornerr.gif) |