lkml.org 
[lkml]   [2022]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH linux-next] soc: qcom: smem_state: Use device_match_of_node()
On Thu, Nov 17, 2022 at 03:48:06PM +0800, ye.xingchen@zte.com.cn wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Replace the open-code with device_match_of_node().
>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
> ---
> drivers/soc/qcom/smem_state.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/qcom/smem_state.c b/drivers/soc/qcom/smem_state.c
> index e848cc9a3cf8..a7844841a727 100644
> --- a/drivers/soc/qcom/smem_state.c
> +++ b/drivers/soc/qcom/smem_state.c
> @@ -63,7 +63,7 @@ static struct qcom_smem_state *of_node_to_state(struct device_node *np)
> mutex_lock(&list_lock);
>
> list_for_each_entry(state, &smem_states, list) {
> - if (state->of_node == np) {
> + if (device_match_of_node(state, np)) {

I don't find this form easier to read, nor is state a struct device *...

Regards,
Bjorn

> kref_get(&state->refcount);
> goto unlock;
> }
> --
> 2.25.1

\
 
 \ /
  Last update: 2022-12-05 23:02    [W:0.198 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site