[lkml]   [2022]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] hfsplus: Add module parameter to enable force writes

> On 04-Dec-2022, at 1:37 PM, Christoph Hellwig <> wrote:
> NAK. Global module options overriding mount options don't make sense.
> If you mount so much write yourself a script, or add the option to the
> configuration of the automounting tool of your choice.

Hi Christoph
My bad I wasn't aware udisks2 now supports custom configuration. I just came to know about this and thus this patch of mine indeed does not make any sense now.

Although, if you think its worth it, the following improvements can be made :-

1. There is no logging showing that writes have been force enabled. We could add that.
2. We could have separate mount options for journaled and locked volumes (although I dunno in what case we get locked volumes).

 \ /
  Last update: 2022-12-04 12:02    [W:0.253 / U:23.916 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site