[lkml]   [2022]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] iio:adc:twl6030: Enable measurements of VUSB, VBAT and others
On Sun, 4 Dec 2022 15:41:52 +0000
Jonathan Cameron <> wrote:

> On Thu, 1 Dec 2022 19:16:35 +0100
> Andreas Kemnade <> wrote:
> > Some inputs need to be wired up to produce proper measurements,
> > without this change only near zero values are reported.
> >
> > Signed-off-by: Andreas Kemnade <>
> Sounds like a fix to me. If so, Fixes tag?

seems to be there since the beginning, to it would be
Fixes: 1696f36482e70 ("iio: twl6030-gpadc: TWL6030, TWL6032 GPADC driver")

I think it was just not used with the charger (which is not in mainline yet),
so it was probably ignored.

> Anything in here we should be turning off again if the driver is removed
> or toggling on suspend? If not, other than the space below this looks fine to me.
I would consider that as configuration, comparing with the nearest relative twl4030,
there a similar bit is set in the probe() without disabling it in the remove().

But I think we should set TWL6030_GPADCR in remove() as we do in suspend(),
but that is another fix.


 \ /
  Last update: 2022-12-04 21:28    [W:0.077 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site