[lkml]   [2022]   [Dec]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] misc: hpilo: Fix use-after-free in ilo_open
On Sat, Dec 31, 2022 at 07:05:36PM +0900, Yoochan Lee wrote:
> Hi,
> I haven't tested with a physical device cause I don't have a real device.
> I found this bug through static analysis.

Then please verify that it actually is a bug and that you have fixed it
properly. To send patches that are broken wastes everyone's time :(

Also, you did not properly describe how the static analysis happened or
what tools reported it as is required.

> This type of bug is similar to [1] and [2].
> And I'm sorry that my patch is incorrect.
> It's my first time patching a Linux kernel myself.

I suggest taking the tutorial on and working in the
drivers/staging/* portion of the kernel first, so that you can learn how
this all works. Do not dive in and assume that fixing issues that a
random tool spits out is even correct to do.

good luck!

greg k-h

 \ /
  Last update: 2023-03-26 23:24    [W:0.087 / U:1.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site