Messages in this thread |  | | From | Miguel Ojeda <> | Date | Sat, 31 Dec 2022 15:25:02 +0100 | Subject | Re: [PATCH] kbuild: rust: move rust/target.json to scripts/ |
| |
On Sat, Dec 31, 2022 at 9:30 AM Masahiro Yamada <masahiroy@kernel.org> wrote: > > scripts/ is a better place to generate files used treewide.
Agreed, and its generator is in `scripts/` already anyway.
> You do not need to add target.json to no-clean-files or MRPROER_FILES.
Maybe adding something like "If moved to `scripts/`, then (...)" would make the sentence a bit more clear.
(Also, typo: `MRPROPER`)
> -$(obj)/core.o: $(RUST_LIB_SRC)/core/src/lib.rs $(obj)/target.json FORCE > +$(obj)/core.o: $(RUST_LIB_SRC)/core/src/lib.rs scripts/target.json FORCE
Should this be `$(srctree)/scripts...` for clarity/consistency? (I see most instances like that elsewhere too)
Cheers, Miguel
|  |