[lkml]   [2022]   [Dec]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] kbuild: rust: move rust/target.json to scripts/
On Sat, Dec 31, 2022 at 9:30 AM Masahiro Yamada <> wrote:
> scripts/ is a better place to generate files used treewide.

Agreed, and its generator is in `scripts/` already anyway.

> You do not need to add target.json to no-clean-files or MRPROER_FILES.

Maybe adding something like "If moved to `scripts/`, then (...)" would
make the sentence a bit more clear.

(Also, typo: `MRPROPER`)

> -$(obj)/core.o: $(RUST_LIB_SRC)/core/src/ $(obj)/target.json FORCE
> +$(obj)/core.o: $(RUST_LIB_SRC)/core/src/ scripts/target.json FORCE

Should this be `$(srctree)/scripts...` for clarity/consistency? (I see
most instances like that elsewhere too)


 \ /
  Last update: 2023-03-26 23:24    [W:0.091 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site