Messages in this thread | | | From | "Rafael J. Wysocki" <> | Date | Fri, 30 Dec 2022 19:43:04 +0100 | Subject | Re: [PATCH v1 1/3] pm: Introduce DEFINE_NOIRQ_DEV_PM_OPS() helper |
| |
On Thu, Dec 29, 2022 at 1:59 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > There are a few drivers and might be more in the future that > open code the functionality of proposed DEFINE_NOIRQ_DEV_PM_OPS() > helper. From now on they may switch to the new helper and save > a few lines of code. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > include/linux/pm.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/include/linux/pm.h b/include/linux/pm.h > index 93cd34f00822..eba96822b1d9 100644 > --- a/include/linux/pm.h > +++ b/include/linux/pm.h > @@ -444,6 +444,11 @@ const struct dev_pm_ops __maybe_unused name = { \ > SET_RUNTIME_PM_OPS(suspend_fn, resume_fn, idle_fn) \ > } > > +#define DEFINE_NOIRQ_DEV_PM_OPS(name, suspend_fn, resume_fn) \ > +const struct dev_pm_ops name = { \ > + NOIRQ_SYSTEM_SLEEP_PM_OPS(suspend_fn, resume_fn) \ > +}
There is NOIRQ_SYSTEM_SLEEP_PM_OPS(), so why is the above needed in addition?
> + > #define pm_ptr(_ptr) PTR_IF(IS_ENABLED(CONFIG_PM), (_ptr)) > #define pm_sleep_ptr(_ptr) PTR_IF(IS_ENABLED(CONFIG_PM_SLEEP), (_ptr)) > > --
| |