lkml.org 
[lkml]   [2022]   [Dec]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] mm: huge_memory: convert split_huge_pages_all() to use a folio
From


On 2022/12/30 16:14, Matthew Wilcox wrote:
> On Thu, Dec 29, 2022 at 08:25:03PM +0800, Kefeng Wang wrote:
>> - if (!PageHead(page) || PageHuge(page) || !PageLRU(page))
>> + if (!folio_test_large(folio)
>> + || folio_test_hugetlb(folio)
>> + || !folio_test_lru(folio))
>> goto next;
>
> That is a completely illegible way of indenting this code! There's
> no visual cue when the condition stops and when the next statement
> begins. Try one of these:
>
sorry about the bad indenting,
> if (!folio_test_large(folio) ||
> folio_test_hugetlb(folio) ||
> !folio_test_lru(folio))
> goto next;
>
will resend with this one, thanks for your review.

\
 
 \ /
  Last update: 2023-03-26 23:23    [W:0.054 / U:0.676 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site