Messages in this thread | | | Date | Fri, 30 Dec 2022 09:21:56 +0100 | Subject | Re: [PATCH v2 1/2] dt-bindings: phy: Add qcom,dp-manual-pullup description | From | Krzysztof Kozlowski <> |
| |
On 29/12/2022 19:34, Bryan O'Donoghue wrote: > The original Qualcomm driver for the HighSpeed USB PHY contains a flag > which tells the driver that the controller and PHY do not connect to VBUS. > > In this case an external IC such as a Type-C port manager supplies VBUS and > the VBUS signal is not routed to the SoC. This means we cannot detect the > presence or absence of VBUS and cannot take action based on it. > > Document the downstream boolean qcom,dp-manual-pullup to allow the HS PHY > implement the necessary logic. > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- > Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml > index aa97478dd0161..c55a59df71ad0 100644 > --- a/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml > @@ -80,6 +80,13 @@ properties: > the address is offset from the ULPI_EXT_VENDOR_SPECIFIC address > - description: value > > + qcom,dp-manual-pullup: > + type: boolean > + description: This flag indicates to the HS USB PHY driver that it should
Drop references to the driver and rephrase it to describe the controller behavior/feature or the board layout/configuration, not the driver. The same applies to property name - "manual pullup" is describing driver, not hardware.
> + enable or disable an internal pullup when powering on or > + powering off the HS PHY instead of toggling the value when VBUS > + is absent or present.
Wrong indentation. It's two spaces.
> + > required: > - clocks > - clock-names
Best regards, Krzysztof
| |