Messages in this thread |  | | Date | Sat, 3 Dec 2022 11:29:31 +0300 | From | Dan Carpenter <> | Subject | Re: net/mptcp/pm_netlink.c:1169 mptcp_pm_parse_pm_addr_attr() warn: missing error code? 'err' |
| |
On Fri, Dec 02, 2022 at 03:38:01PM -0800, Mat Martineau wrote: > > 01cacb00b35cb6 Paolo Abeni 2020-03-27 1158 /* no validation needed - was already done via nested policy */ > > 01cacb00b35cb6 Paolo Abeni 2020-03-27 1159 err = nla_parse_nested_deprecated(tb, MPTCP_PM_ADDR_ATTR_MAX, attr, > > 01cacb00b35cb6 Paolo Abeni 2020-03-27 1160 mptcp_pm_addr_policy, info->extack); > > 01cacb00b35cb6 Paolo Abeni 2020-03-27 1161 if (err) > > 01cacb00b35cb6 Paolo Abeni 2020-03-27 1162 return err; > > 01cacb00b35cb6 Paolo Abeni 2020-03-27 1163 > > 982f17ba1a2534 Florian Westphal 2022-05-03 1164 if (tb[MPTCP_PM_ADDR_ATTR_ID]) > > 982f17ba1a2534 Florian Westphal 2022-05-03 1165 addr->id = nla_get_u8(tb[MPTCP_PM_ADDR_ATTR_ID]); > > 982f17ba1a2534 Florian Westphal 2022-05-03 1166 > > 01cacb00b35cb6 Paolo Abeni 2020-03-27 1167 if (!tb[MPTCP_PM_ADDR_ATTR_FAMILY]) { > > 01cacb00b35cb6 Paolo Abeni 2020-03-27 1168 if (!require_family) > > 982f17ba1a2534 Florian Westphal 2022-05-03 @1169 return err; > > > > "err" is zero at this point. Presumably a negative error code was > > intended. > > Hi Dan - > > The intended error code is 0 here: the return happens if no > MPTCP_PM_ADDR_ATTR_FAMILY value is present and require_family is false. > > It would be clearer to "return 0;", but the code is working as expected. > > > Could you be sure to cc mptcp@lists.linux.dev and > matthieu.baerts@tessares.net for future MPTCP issues?
These emails are automatically generated by the kbuild team. I don't know what kind of heuristics they use... I've put them on the To header. There is probably a reason why they don't just use get_maintainer.pl...
regards, dan carpenter
|  |