lkml.org 
[lkml]   [2022]   [Dec]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] selftests: net: fix cmsg_so_mark.sh test hang
    Date
    This cmsg_so_mark.sh test will hang on non-amd64 systems because of the
    infinity loop for argument parsing in cmsg_sender.

    Variable "o" in cs_parse_args() for taking getopt() should be an int,
    otherwise it will be 255 when getopt() returns -1 on non-amd64 system
    and thus causing infinity loop.

    Link: https://lore.kernel.org/lkml/CA+G9fYsM2k7mrF7W4V_TrZ-qDauWM394=8yEJ=-t1oUg8_40YA@mail.gmail.com/t/
    Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
    ---
    tools/testing/selftests/net/cmsg_sender.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/tools/testing/selftests/net/cmsg_sender.c b/tools/testing/selftests/net/cmsg_sender.c
    index 75dd83e..24b21b1 100644
    --- a/tools/testing/selftests/net/cmsg_sender.c
    +++ b/tools/testing/selftests/net/cmsg_sender.c
    @@ -110,7 +110,7 @@ static void __attribute__((noreturn)) cs_usage(const char *bin)

    static void cs_parse_args(int argc, char *argv[])
    {
    - char o;
    + int o;

    while ((o = getopt(argc, argv, "46sS:p:m:M:d:tf:F:c:C:l:L:H:")) != -1) {
    switch (o) {
    --
    2.7.4
    \
     
     \ /
      Last update: 2023-03-26 23:22    [W:6.324 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site