Messages in this thread | | | Date | Thu, 29 Dec 2022 22:41:12 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v8 3/4] fpga: dfl: add basic support for DFHv1 |
| |
On Thu, Dec 29, 2022 at 08:18:03AM -0800, Tom Rix wrote: > On 12/28/22 10:16 AM, matthew.gerlach@linux.intel.com wrote:
...
> > struct dfl_feature_info { > > u16 fid; > > u8 revision; > > + u8 dfh_version; > > struct resource mmio_res; > > void __iomem *ioaddr; > > struct list_head node; > > unsigned int irq_base; > > unsigned int nr_irqs; > > + unsigned int param_size; > > + u64 params[]; > u64 *params
This will break the overflow.h macros, no? Besides that it will break the code for sure as it's not an equivalent.
> > };
-- With Best Regards, Andy Shevchenko
| |