Messages in this thread | | | Date | Thu, 29 Dec 2022 18:35:29 +0100 | Subject | Re: [PATCH v2 3/5] iio: pressure: bmp280: Add support for new sensor BMP580 | From | Christophe JAILLET <> |
| |
Le 26/12/2022 à 15:29, Angel Iglesias a écrit : > Adds compatibility with the new sensor generation, the BMP580. > > The measurement and initialization codepaths are adapted from > the device datasheet and the repository from manufacturer at > https://github.com/boschsensortec/BMP5-Sensor-API. > > Signed-off-by: Angel Iglesias <ang.iglesiasg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> >
[...]
> diff --git a/drivers/iio/pressure/bmp280.h b/drivers/iio/pressure/bmp280.h > index efc31bc84708..27d2abc17d01 100644 > --- a/drivers/iio/pressure/bmp280.h > +++ b/drivers/iio/pressure/bmp280.h
[...]
> +#define BMP580_CHIP_ID 0x50 > #define BMP380_CHIP_ID 0x50
Hi,
this is maybe correct (I've not been able to find the datasheet to check myself), but it looks odd to have the same ID for 2 different chips.
CJ
> #define BMP180_CHIP_ID 0x55 > #define BMP280_CHIP_ID 0x58
| |