Messages in this thread | | | Date | Thu, 29 Dec 2022 04:59:23 +0200 | From | Laurent Pinchart <> | Subject | Re: [PATCH RESEND v2 2/7] media: uvcvideo: improve error logging in uvc_query_ctrl() |
| |
Hi Ricardo and Hans,
Thank you for the patch.
On Fri, Dec 02, 2022 at 06:21:36PM +0100, Ricardo Ribalda wrote: > From: Hans Verkuil <hverkuil-cisco@xs4all.nl> > > If __uvc_query_ctrl() failed with a non-EPIPE error, then > report that with dev_err. If an error code is obtained, then > report that with dev_dbg.
The commit message should explain why this is desirable.
> Reviewed-by: Ricardo Ribalda <ribalda@chromium.org> > Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> > --- > drivers/media/usb/uvc/uvc_video.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/drivers/media/usb/uvc/uvc_video.c b/drivers/media/usb/uvc/uvc_video.c > index 170a008f4006..2cf7f692c0bb 100644 > --- a/drivers/media/usb/uvc/uvc_video.c > +++ b/drivers/media/usb/uvc/uvc_video.c > @@ -79,13 +79,14 @@ int uvc_query_ctrl(struct uvc_device *dev, u8 query, u8 unit, > if (likely(ret == size)) > return 0; > > - dev_err(&dev->udev->dev, > - "Failed to query (%s) UVC control %u on unit %u: %d (exp. %u).\n", > - uvc_query_name(query), cs, unit, ret, size); > - > - if (ret != -EPIPE) > + if (ret != -EPIPE) { > + dev_err(&dev->udev->dev, > + "Failed to query (%s) UVC control %u on unit %u: %d (exp. %u).\n", > + uvc_query_name(query), cs, unit, ret, size); > return ret; > + } > > + /* reuse data[0] to request the error code. */
s/reuse/Reuse/
> tmp = *(u8 *)data; > > ret = __uvc_query_ctrl(dev, UVC_GET_CUR, 0, intfnum, >
-- Regards,
Laurent Pinchart
| |