Messages in this thread | | | Date | Thu, 29 Dec 2022 04:25:55 +0200 | From | Laurent Pinchart <> | Subject | Re: [PATCH RESEND v2 1/2] media: uvcvideo: Limit power line control for Acer EasyCamera |
| |
Hi Ricardo,
Thank you for the patch.
On Fri, Dec 02, 2022 at 05:45:06PM +0100, Ricardo Ribalda wrote: > The device does not implement the power line control correctly. Add a > corresponding control mapping override. > > Bus 003 Device 002: ID 5986:1180 Acer, Inc EasyCamera > Device Descriptor: > bLength 18 > bDescriptorType 1 > bcdUSB 2.00 > bDeviceClass 239 Miscellaneous Device > bDeviceSubClass 2 > bDeviceProtocol 1 Interface Association > bMaxPacketSize0 64 > idVendor 0x5986 Acer, Inc > idProduct 0x1180 > bcdDevice 56.04 > iManufacturer 3 Bison > iProduct 1 EasyCamera > iSerial 2 > bNumConfigurations 1
If you have the full descriptors for this device, could you send them to me ?
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org> > Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> --- > drivers/media/usb/uvc/uvc_driver.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c > index 215fb483efb0..cca3012c8912 100644 > --- a/drivers/media/usb/uvc/uvc_driver.c > +++ b/drivers/media/usb/uvc/uvc_driver.c > @@ -2994,6 +2994,15 @@ static const struct usb_device_id uvc_ids[] = { > .bInterfaceSubClass = 1, > .bInterfaceProtocol = 0, > .driver_info = (kernel_ulong_t)&uvc_ctrl_power_line_limited }, > + /* Acer EasyCamera */ > + { .match_flags = USB_DEVICE_ID_MATCH_DEVICE > + | USB_DEVICE_ID_MATCH_INT_INFO, > + .idVendor = 0x5986, > + .idProduct = 0x1180, > + .bInterfaceClass = USB_CLASS_VIDEO, > + .bInterfaceSubClass = 1, > + .bInterfaceProtocol = 0, > + .driver_info = (kernel_ulong_t)&uvc_ctrl_power_line_limited }, > /* Intel RealSense D4M */ > { .match_flags = USB_DEVICE_ID_MATCH_DEVICE > | USB_DEVICE_ID_MATCH_INT_INFO, >
-- Regards,
Laurent Pinchart
| |