Messages in this thread | | | From | Ping-Ke Shih <> | Subject | RE: [RFC PATCH v1 18/19] rtw88: Add support for the SDIO based RTL8822CS chipset | Date | Thu, 29 Dec 2022 01:40:16 +0000 |
| |
> -----Original Message----- > From: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > Sent: Wednesday, December 28, 2022 7:30 AM > To: linux-wireless@vger.kernel.org > Cc: Yan-Hsuan Chuang <tony0620emma@gmail.com>; Kalle Valo <kvalo@kernel.org>; Ulf Hansson > <ulf.hansson@linaro.org>; linux-kernel@vger.kernel.org; netdev@vger.kernel.org; > linux-mmc@vger.kernel.org; Chris Morgan <macroalpha82@gmail.com>; Nitin Gupta <nitin.gupta981@gmail.com>; > Neo Jou <neojou@gmail.com>; Ping-Ke Shih <pkshih@realtek.com>; Jernej Skrabec <jernej.skrabec@gmail.com>; > Martin Blumenstingl <martin.blumenstingl@googlemail.com> > Subject: [RFC PATCH v1 18/19] rtw88: Add support for the SDIO based RTL8822CS chipset > > Wire up RTL8822CS chipset support using the new rtw88 SDIO HCI code as > well as the existing RTL8822C chipset code. > > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > --- > drivers/net/wireless/realtek/rtw88/Kconfig | 11 ++++++ > drivers/net/wireless/realtek/rtw88/Makefile | 3 ++ > .../net/wireless/realtek/rtw88/rtw8822cs.c | 34 +++++++++++++++++++ > 3 files changed, 48 insertions(+) > create mode 100644 drivers/net/wireless/realtek/rtw88/rtw8822cs.c >
[...]
> diff --git a/drivers/net/wireless/realtek/rtw88/rtw8822cs.c > b/drivers/net/wireless/realtek/rtw88/rtw8822cs.c > new file mode 100644 > index 000000000000..3d7279d70aa9 > --- /dev/null > +++ b/drivers/net/wireless/realtek/rtw88/rtw8822cs.c > @@ -0,0 +1,34 @@ > +// SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause > +// Copyright(c) Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Normally, we should use '/* ... */' style comment. The exception is '// SPDX-License-Identifier: ...' in *.c
Therefore, here should be:
// SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause /* Copyright(c) Martin Blumenstingl <martin.blumenstingl@googlemail.com> */
As well as other rtw88*s.c
-- Ping-Ke
| |