Messages in this thread | | | Date | Wed, 28 Dec 2022 13:38:48 +0100 | Subject | Re: [PATCH 1/2] dt-bindings: remoteproc: k3-dsp: update bindings for AM62A SoCs | From | Krzysztof Kozlowski <> |
| |
On 28/12/2022 13:36, Hari Nagalla wrote: > The TI AM62A SoCs have a C7xv DSP and Analytics engine for deep > learning purposes. The DSP part is similar to the C71x DSP found on > K3 J7 SoCs, but additional hardware accelerators and IP are added to > the subsystem for deep learning. > > Compatible info is updated to match AM62A SoCs. > > Signed-off-by: Hari Nagalla <hnagalla@ti.com> > --- > .../devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml > index cedbc5efdc56..846c9c14169a 100644 > --- a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml > +++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml > @@ -34,10 +34,12 @@ properties: > - ti,j721e-c66-dsp > - ti,j721e-c71-dsp > - ti,j721s2-c71-dsp > + - ti,am62a-c7xv-dsp
Add it in some order, e.g. alphabetical.
> description: > Use "ti,j721e-c66-dsp" for C66x DSPs on K3 J721E SoCs > Use "ti,j721e-c71-dsp" for C71x DSPs on K3 J721E SoCs > Use "ti,j721s2-c71-dsp" for C71x DSPs on K3 J721S2 SoCs > + Use "ti,am62a-c7xv-dsp" for AM62A Deep learning DSPs on K3 AM62A SoCs > > resets: > description: | > @@ -111,6 +113,7 @@ else: > enum: > - ti,j721e-c71-dsp > - ti,j721s2-c71-dsp > + - ti,am62a-c7xv-dsp
Does not look like you tested the bindings. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions).
Wrong indentation.
Best regards, Krzysztof
| |