Messages in this thread | | | Subject | Re: [PATCH] mce: fix missing stack-dumping in mce_panic() | From | Miaohe Lin <> | Date | Wed, 28 Dec 2022 20:33:31 +0800 |
| |
On 2022/12/10 10:28, Miaohe Lin wrote: > On 2022/12/3 0:37, Miaohe Lin wrote: >> When machine check exception occurs, there is no stack-dumping now in >> mce_panic(). It's because bust_spinlocks(1) is called prematurely so >> oops_in_progress will be >= 2 when trying to call dump_stack() in >> panic(). Thus dump_stack() won't be called as this is considered as >> nested stack-dumping. >> >> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> > > Friendly ping. ;)
Friendly ping after busy merge window. :)
> >> --- >> arch/x86/kernel/cpu/mce/core.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c >> index 2c8ec5c71712..c40dad1a6749 100644 >> --- a/arch/x86/kernel/cpu/mce/core.c >> +++ b/arch/x86/kernel/cpu/mce/core.c >> @@ -254,7 +254,6 @@ static noinstr void mce_panic(const char *msg, struct mce *final, char *exp) >> wait_for_panic(); >> barrier(); >> >> - bust_spinlocks(1); >> console_verbose(); >> } else { >> /* Don't log too much for fake panic */ >> >
| |