Messages in this thread | | | Date | Wed, 28 Dec 2022 12:53:27 +0100 | From | "Luca Weiss" <> | Subject | Re: [PATCH] dt-bindings: ufs: qcom: Add reg-names property for ICE |
| |
Hi Krzysztof,
On Wed Dec 28, 2022 at 12:50 PM CET, Krzysztof Kozlowski wrote: > On 09/12/2022 15:29, Luca Weiss wrote: > > The code in ufs-qcom-ice.c needs the ICE reg to be named "ice". Add this > > in the bindings so the existing dts can validate successfully. > > > > Also sm8450 is using ICE since commit 276ee34a40c1 ("arm64: dts: qcom: > > sm8450: add Inline Crypto Engine registers and clock") so move the > > compatible to the correct if. > > > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> > > --- > > (no cover subject) > > > > The only remaining validation issues I see is the following on sc8280xp-crd.dtb > > and sa8540p-ride.dtb: > > > > Any plans on fixing the patch (after testing it) and resending?
I wasn't quite sure how to fix the comments, but re-reading them this comment from you is how you expect it to be in v2?
> Just add it to top-level with minItems: 1 and per variant customize: > 1. maxItems: 1 > 2. minItems: 2 + required
If so I can spin v2 maybe today still.
Regards Luca
> > Best regards, > Krzysztof
| |