Messages in this thread | | | Date | Wed, 28 Dec 2022 16:41:51 +0530 | From | Vinod Koul <> | Subject | Re: [PATCH] dmaengine: HISI_DMA should depend on ARCH_HISI |
| |
On 21-11-22, 16:23, Geert Uytterhoeven wrote: > The HiSilicon DMA Engine is only present on HiSilicon SoCs. Hence add a > dependency on ARCH_HISI, to prevent asking the user about this driver > when configuring a kernel without HiSilicon SoC support. > > Fixes: e9f08b65250d73ab ("dmaengine: hisilicon: Add Kunpeng DMA engine support")
My script warns of bad tag, so I looked up.. this one uses 16 chars of SHA1... checkpatch also complains: Please use correct Fixes: style 'Fixes: <12 chars of sha1>...
I guess lots of parts assume that it shall be _exactly_ 12!
I have applied it ..
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > drivers/dma/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig > index b9d54f20812f794b..67323afe9fcad137 100644 > --- a/drivers/dma/Kconfig > +++ b/drivers/dma/Kconfig > @@ -245,7 +245,7 @@ config FSL_RAID > > config HISI_DMA > tristate "HiSilicon DMA Engine support" > - depends on ARM64 || COMPILE_TEST > + depends on ARCH_HISI || COMPILE_TEST > depends on PCI_MSI > select DMA_ENGINE > select DMA_VIRTUAL_CHANNELS > -- > 2.25.1
-- ~Vinod
| |