Messages in this thread | | | Date | Tue, 27 Dec 2022 15:45:09 +0200 | From | Leon Romanovsky <> | Subject | Re: [PATCH] octeontx2_pf: Select NET_DEVLINK when enabling OCTEONTX2_PF |
| |
On Mon, Dec 19, 2022 at 12:11:28PM -0500, Paul Gazzillo wrote: > When using COMPILE_TEST, the driver controlled by OCTEONTX2_PF does > not select NET_DEVLINK while the related OCTEONTX2_AF driver does. > This means that when OCTEONTX2_PF is enabled from a default > configuration, linker errors will occur due to undefined references to > code controlled by NET_DEVLINK. > > 1. make.cross ARCH=x86_64 defconfig > 2. make.cross ARCH=x86_64 menuconfig > 3. Enable COMPILE_TEST > General setup ---> > Compile also drivers which will not load > 4. Enable OCTEONTX2_PF > Device Drivers ---> > Network device support ---> > Ethernet driver support ---> > Marvell OcteonTX2 NIC Physical Function driver > 5. Exit and save configuration. NET_DEVLINK will still be disabled. > 6. make.cross ARCH=x86_64 several linker errors, for example, > ld: drivers/net/ethernet/marvell/octeontx2/nic/otx2_devlink.o: > in function `otx2_register_dl': > otx2_devlink.c:(.text+0x142): undefined reference to `devlink_alloc_ns' > > This fix adds "select NET_DEVLINK" link to OCTEONTX2_PF's Kconfig > specification to match OCTEONTX2_AF. > > Fixes: 2da489432747 ("octeontx2-pf: devlink params support to set mcam entry count") > Signed-off-by: Paul Gazzillo <paul@pgazz.com> > --- > v1 -> v2: Added the fixes tag > > drivers/net/ethernet/marvell/octeontx2/Kconfig | 1 + > 1 file changed, 1 insertion(+) >
Thanks, Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
| |