| Date | Mon, 26 Dec 2022 13:23:18 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCHv8 02/14] mm: Add support for unaccepted memory |
| |
On Wed, Dec 07, 2022 at 04:49:21AM +0300, Kirill A. Shutemov wrote: > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 6e60657875d3..6d597e833a73 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -450,6 +450,11 @@ EXPORT_SYMBOL(nr_online_nodes); > > int page_group_by_mobility_disabled __read_mostly; > > +#ifdef CONFIG_UNACCEPTED_MEMORY > +/* Counts number of zones with unaccepted pages. */ > +static DEFINE_STATIC_KEY_FALSE(unaccepted_pages);
Then call it what it is:
static DEFINE_STATIC_KEY_FALSE(zones_with_unaccepted_pages);
so that when reading the code it is self-describing:
if (!static_branch_unlikely(&zones_with_unaccepted_pages)) return false;
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
|