lkml.org 
[lkml]   [2022]   [Dec]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3 6/7] riscv: dts: starfive: Add initial StarFive JH7110 device tree
From
On 25/12/2022 11:31, Hal Feng wrote:

>
> gmac0_rmii_refin: clock {
> ...
> };
>
> gmac0_rgmii_rxin: clock {
> ...
> };
> ...
>
>> nothing. It looks like you avoid to define proper clock controller.
>> What's the point for all these clocks? These are no-op.
>
> These are all external fixed rate clocks inputted to the SoC. They are the root

If they are all external, then it is fine.

>
>>
>>> + compatible = "fixed-clock";
>>> + #clock-cells = <0>;
>>> + };

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2023-03-26 23:19    [W:0.135 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site