Messages in this thread |  | | From | Frank Wunderlich <> | Subject | Aw: Re: [next v7 8/8] arm64: dts: mt7986: add Bananapi R3 | Date | Sun, 25 Dec 2022 12:47:02 +0100 |
| |
Hi
> Gesendet: Samstag, 24. Dezember 2022 um 20:00 Uhr > Von: "Daniel Golle" <daniel@makrotopia.org>
> > --- /dev/null > > +++ b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3-emmc.dtso > > @@ -0,0 +1,30 @@ > > +// SPDX-License-Identifier: (GPL-2.0 OR MIT) > > +/* > > + * Copyright (C) 2021 MediaTek Inc. > > + * Author: Sam.Shih <sam.shih@mediatek.com> > > + */ > > + > > +/dts-v1/; > > +/plugin/; > > + > > +/ { > > + compatible = "bananapi,bpi-r3", "mediatek,mt7986a"; > > + model = "Bananapi BPI-R3 (emmc)"; > > Why do you set the model string here?
seems to be a left over from testing where i wanted to see which base-dtb was loaded without comparing mmc-node settings. Was easier to see with model-string :)
> > + > > + fragment@0 { > > + target-path = "/soc/mmc@11230000"; > > + __overlay__ { > > + bus-width = <8>; > > + max-frequency = <200000000>; > > + cap-mmc-highspeed; > > + mmc-hs200-1_8v; > > + mmc-hs400-1_8v; > > + hs400-ds-delay = <0x14014>; > > + non-removable; > > + no-sd; > > + no-sdio; > > + status = "okay"; > > + }; > > + }; > > +};
> > diff --git a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts > > new file mode 100644 > > index 000000000000..618d3bb2f32f > > --- /dev/null > > +++ b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
> > +&mdio { > > + switch: switch@31 { > > + compatible = "mediatek,mt7531"; > > + reg = <31>; > > + reset-gpios = <&pio 5 GPIO_ACTIVE_HIGH>; > > Please add: > > interrupt-controller; > #interrupt-cells = <1>; > interrupt-parent = <&pio>; > interrupts = <66 IRQ_TYPE_LEVEL_HIGH>; > > to have IRQ driven phy status instead of having to poll the link status > of the 5x rj-45 ports. > The value comes from schematics (pin AD24, GPIO66, 7531_INT) and I've > tested this on my board.
ok, if you have it tested i add these properties in next version (and test it too). I wait for tphy-binding to be applied to next (pcie and xhci already in torvalds/master).
> > + }; > > +}; > > +
> > +&spi0 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&spi_flash_pins>; > > + cs-gpios = <0>, <0>; > > I don't think those bogus cs-gpios here and for spi1 below are needed.
can drop them in next version
> > + status = "okay"; > > +}; > > + > > +&spi1 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&spic_pins>; > > + cs-gpios = <0>, <0>; > > + status = "okay"; > > +}; > > +
regards Frank
|  |