lkml.org 
[lkml]   [2022]   [Dec]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCHv1 linux-next 1/4] dt-bindings: net: rockchip-dwmac: fix rv1126 compatible warning
    On Sat, Dec 24, 2022 at 9:30 AM Jagan Teki <jagan@edgeble.ai> wrote:
    >
    > On Fri, 23 Dec 2022 at 18:55, Anand Moon <anand@edgeble.ai> wrote:
    > >
    > > Fix compatible string for RV1126 gmac, and constrain it to
    > > be compatible with Synopsys dwmac 4.20a.
    > >
    > > fix below warning
    > > arch/arm/boot/dts/rv1126-edgeble-neu2-io.dtb: ethernet@ffc40000:
    > > compatible: 'oneOf' conditional failed, one must be fixed:
    > > ['rockchip,rv1126-gmac', 'snps,dwmac-4.20a'] is too long
    > > 'rockchip,rv1126-gmac' is not one of ['rockchip,rk3568-gmac', 'rockchip,rk3588-gmac']
    > >
    > > Signed-off-by: Anand Moon <anand@edgeble.ai>
    > > Signed-off-by: Jagan Teki <jagan@edgeble.ai>
    > > ---
    >
    > Please add Fixes above SoB.

    That and, shouldn't the Signed-off-by: tags be reversed if Anand is
    sending this?

    Confused,

    -- Slade

    \
     
     \ /
      Last update: 2023-03-26 23:19    [W:6.392 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site