lkml.org 
[lkml]   [2022]   [Dec]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH linux-next] lib: Dhrystone: initialize ret value
On Sat, Dec 24, 2022 at 01:06:40PM +0800, Zhouyi Zhou wrote:
> Initialize ret value whenever 'if' condition is false in dhry_run_set.
>
> Signed-off-by: Zhouyi Zhou <zhouzhouyi@gmail.com>
> ---
> Dear Developers:
> When I invoke make bzImage LLVM=1, clang complains followings:
> lib/dhry_run.c:61:6: error: variable 'ret' is used uninitialized whenever 'if' condition is false
>
> Fix above complain by initialize the ret value.
>
> Thanks
> Zhouyi

Thank you for the patch! I think this has already been fixed:

https://lore.kernel.org/20221219221045.0ABAEC433D2@smtp.kernel.org/

-next is on a break so it won't be there for a bit:

https://lore.kernel.org/20221220112148.64f183ce@canb.auug.org.au/

Cheers,
Nathan

> --
> lib/dhry_run.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/dhry_run.c b/lib/dhry_run.c
> index 31a1d442e4a0..be86e5126c29 100644
> --- a/lib/dhry_run.c
> +++ b/lib/dhry_run.c
> @@ -64,6 +64,7 @@ static int dhry_run_set(const char *val, const struct kernel_param *kp)
> return ret;
> } else {
> dhry_run = true;
> + ret = 0;
> }
>
> if (dhry_run && system_state == SYSTEM_RUNNING)
> --
> 2.34.1
>

\
 
 \ /
  Last update: 2023-03-26 23:19    [W:0.028 / U:1.404 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site