lkml.org 
[lkml]   [2022]   [Dec]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 01/13] blk-mq: avoid sleep in blk_mq_alloc_request_hctx
On Fri, Dec 23, 2022 at 08:52:11PM +0800, Kemeng Shi wrote:
> + if (WARN_ON_ONCE(((!flags) & (BLK_MQ_REQ_NOWAIT | BLK_MQ_REQ_RESERVED))))

This check does not make any sense. I think what you want is

if (WARN_ON_ONCE(!(flags & BLK_MQ_REQ_NOWAIT) ||
WARN_ON_ONCE(!(flags & BLK_MQ_REQ_RESERVED))))

\
 
 \ /
  Last update: 2023-03-26 23:18    [W:1.113 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site