Messages in this thread | | | Date | Fri, 23 Dec 2022 00:12:54 +0100 | From | Uwe Kleine-König <> | Subject | Re: [PATCH 595/606] w1: ds2482: Convert to i2c's .probe_new() |
| |
Hello Evgeniy,
On Fri, Nov 18, 2022 at 11:45:29PM +0100, Uwe Kleine-König wrote: > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > --- > drivers/w1/masters/ds2482.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/w1/masters/ds2482.c b/drivers/w1/masters/ds2482.c > index 62c44616d8a9..3d8b51316bef 100644 > --- a/drivers/w1/masters/ds2482.c > +++ b/drivers/w1/masters/ds2482.c > @@ -442,8 +442,7 @@ static u8 ds2482_w1_set_pullup(void *data, int delay) > } > > > -static int ds2482_probe(struct i2c_client *client, > - const struct i2c_device_id *id) > +static int ds2482_probe(struct i2c_client *client) > { > struct ds2482_data *data; > int err = -ENODEV; > @@ -553,7 +552,7 @@ static struct i2c_driver ds2482_driver = { > .driver = { > .name = "ds2482", > }, > - .probe = ds2482_probe, > + .probe_new = ds2482_probe, > .remove = ds2482_remove, > .id_table = ds2482_id, > };
Assuming you don't have any concerns, it would be great if you applied this patch for the next merge window.
Best regards Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | [unhandled content-type:application/pgp-signature] | |