lkml.org 
[lkml]   [2022]   [Dec]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH printk v3 5/6] printk: introduce console_get_next_message() and console_message
Date
On 2022-12-21, John Ogness <john.ogness@linutronix.de> wrote:
> +static bool console_emit_next_record(struct console *con, bool *handover, int cookie)
> +{
> + bool is_extended = console_srcu_read_flags(con) & CON_EXTENDED;
> + static char dropped_text[DROPPED_TEXT_MAX];
> + static struct console_buffers cbufs;
> + static struct console_message cmsg = {
> + .cbufs = &cbufs,
> + };

@cmsg should not be static. The whole point of the console_message
wrapper struct is so that it can sit on the stack.

John Ogness

\
 
 \ /
  Last update: 2023-03-26 23:18    [W:0.269 / U:0.992 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site