Messages in this thread | | | From | John Ogness <> | Subject | Re: [PATCH printk v3 5/6] printk: introduce console_get_next_message() and console_message | Date | Thu, 22 Dec 2022 16:47:39 +0106 |
| |
On 2022-12-21, John Ogness <john.ogness@linutronix.de> wrote: > +static bool console_emit_next_record(struct console *con, bool *handover, int cookie) > +{ > + bool is_extended = console_srcu_read_flags(con) & CON_EXTENDED; > + static char dropped_text[DROPPED_TEXT_MAX]; > + static struct console_buffers cbufs; > + static struct console_message cmsg = { > + .cbufs = &cbufs, > + };
@cmsg should not be static. The whole point of the console_message wrapper struct is so that it can sit on the stack.
John Ogness
| |