lkml.org 
[lkml]   [2022]   [Dec]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 1/3] mm: vmalloc: Avoid of calling __find_vmap_area() twise in __vunmap()
> A sorry.  I need more coffee, this is not the cover letter, but the
> patch that introduceѕ find_unlink_vmap_area.
>
Sorry. I should post it with a cover latter to make it less confusing.

> > - spin_lock(&vmap_area_lock);
> > - unlink_va(va, &vmap_area_root);
> > - spin_unlock(&vmap_area_lock);
> > + if (!list_empty(&va->list)) {
> > + spin_lock(&vmap_area_lock);
> > + unlink_va(va, &vmap_area_root);
> > + spin_unlock(&vmap_area_lock);
> > + }
>
> As mentioned before, I'd much rather move this into the callers.
>
Agree. There is only one caller, it is the free_vmap_block().
Will fix in the v3.

> > + va = find_unlink_vmap_area((unsigned long) addr);
> > + return __remove_vm_area(va);
>
> This can drop the va local variable now.
>
Do you mean like:

struct vm_struct *remove_vm_area(const void *addr)
{
might_sleep();
return __remove_vm_area(
find_unlink_vmap_area((unsigned long) addr));
}

?

Thanks for review!

--
Uladzislau Rezki

\
 
 \ /
  Last update: 2023-03-26 23:17    [W:0.097 / U:0.664 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site