lkml.org 
[lkml]   [2022]   [Dec]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v5 14/23] scsi: ufs: ufs-qcom: Remove un-necessary WARN_ON()
    Date
    In the reset assert and deassert callbacks, the supplied "id" is not used
    at all and only the hba reset is performed all the time. So there is no
    reason to use a WARN_ON on the "id".

    Reviewed-by: Andrew Halaney <ahalaney@redhat.com>
    Reviewed-by: Asutosh Das <quic_asutoshd@quicinc.com>
    Tested-by: Andrew Halaney <ahalaney@redhat.com> # Qdrive3/sa8540p-ride
    Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
    ---
    drivers/ufs/host/ufs-qcom.c | 4 ----
    1 file changed, 4 deletions(-)

    diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
    index 7cd996ac180b..8bb0f4415f1a 100644
    --- a/drivers/ufs/host/ufs-qcom.c
    +++ b/drivers/ufs/host/ufs-qcom.c
    @@ -895,8 +895,6 @@ ufs_qcom_reset_assert(struct reset_controller_dev *rcdev, unsigned long id)
    {
    struct ufs_qcom_host *host = rcdev_to_ufs_host(rcdev);

    - /* Currently this code only knows about a single reset. */
    - WARN_ON(id);
    ufs_qcom_assert_reset(host->hba);
    /* provide 1ms delay to let the reset pulse propagate. */
    usleep_range(1000, 1100);
    @@ -908,8 +906,6 @@ ufs_qcom_reset_deassert(struct reset_controller_dev *rcdev, unsigned long id)
    {
    struct ufs_qcom_host *host = rcdev_to_ufs_host(rcdev);

    - /* Currently this code only knows about a single reset. */
    - WARN_ON(id);
    ufs_qcom_deassert_reset(host->hba);

    /*
    --
    2.25.1
    \
     
     \ /
      Last update: 2023-03-26 23:17    [W:4.338 / U:0.224 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site