Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Thu, 22 Dec 2022 14:05:26 +0100 | Subject | Re: [PATCH v2] kbuild: treat char as always unsigned |
| |
Hi Linus,
On Wed, Dec 21, 2022 at 7:46 PM Linus Torvalds <torvalds@linux-foundation.org> wrote: > On Wed, Dec 21, 2022 at 9:19 AM Guenter Roeck <linux@roeck-us.net> wrote: > > On Wed, Dec 21, 2022 at 09:06:41AM -0800, Linus Torvalds wrote: > > > I think the real fix is to just remove that broken implementation > > > entirely, and rely on the generic one. > > > > Perfectly fine with me. > > That got pushed out as commit 7c0846125358 ("m68k: remove broken > strcmp implementation") but it's obviously entirely untested. I don't > do m68k cross-compiles, much less boot tests. > > Just FYI for everybody - I may have screwed something up for some very > non-obvious reason. > > But it looked very obvious indeed, and I hate having buggy code that > is architecture-specific when we have generic code that isn't buggy.
Thank you for being proactive! It works fine (and slightly reduced kernel size, too ;-)
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |