Messages in this thread | | | Date | Thu, 22 Dec 2022 12:38:22 +0000 | From | Lorenzo Stoakes <> | Subject | Re: [PATCH] mm: remove unused alloc_pages_bulk_list() |
| |
On Thu, Dec 22, 2022 at 02:03:46AM -0800, Christoph Hellwig wrote: > Is that being snarky? :) We generally don't add dead code at all, and > certaintly don't leave it around for a year and a half. > > If anyone really needs this we can add it back. >
Mel has replied elsewhere on this thread and we have a potential user so I think the lowest-impact approach is to go with what he suggested - wait until May and see if we have any takers.
I have put a reminder in my calendar for then, I'll check to see if it's being used anywhere, if not I'll respin this patch. So problem solved for everyone :)
> > Also, if we do get rid of this, then __alloc_pages_bulk() can lose > > the "list" argument. > > Yepp.
Yeah the respin will take this into account, if the function remains unused in May.
| |