Messages in this thread | | | Date | Thu, 22 Dec 2022 13:16:04 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH RFC v7 01/64] KVM: Fix memslot boundary condition for large page |
| |
On Wed, Dec 14, 2022 at 01:39:53PM -0600, Michael Roth wrote: > From: Nikunj A Dadhania <nikunj@amd.com> > > Aligned end boundary causes a kvm crash, handle the case. > > Signed-off-by: Nikunj A Dadhania <nikunj@amd.com> > Signed-off-by: Michael Roth <michael.roth@amd.com> > --- > arch/x86/kvm/mmu/mmu.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c > index b1953ebc012e..b3ffc61c668c 100644 > --- a/arch/x86/kvm/mmu/mmu.c > +++ b/arch/x86/kvm/mmu/mmu.c > @@ -7159,6 +7159,9 @@ static void kvm_update_lpage_private_shared_mixed(struct kvm *kvm, > for (gfn = first + pages; gfn < last; gfn += pages) > linfo_set_mixed(gfn, slot, level, false); > > + if (gfn == last) > + goto out;
I'm guessing this was supposed to be "return;" here:
arch/x86/kvm/mmu/mmu.c: In function ‘kvm_update_lpage_private_shared_mixed’: arch/x86/kvm/mmu/mmu.c:7090:25: error: label ‘out’ used but not defined 7090 | goto out; | ^~~~
/me goes and digs deeper.
Aha, it was a "return" but you reordered the patches and the one adding the out label:
KVM: x86: Add 'update_mem_attr' x86 op
went further down and this became the first but it didn't have the label anymore.
Yeah, each patch needs to build successfully for bisection reasons, ofc.
Thx.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |