Messages in this thread | | | Date | Thu, 22 Dec 2022 06:50:11 +0100 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH v2 2/2] usb: misc: onboard_hub: Fail silently when there is no platform device |
| |
On Thu, Dec 22, 2022 at 02:26:45AM +0000, Matthias Kaehlcke wrote: > Some boards with an onboard USB hub supported by the onboard_hub > driver have a device tree node for the hub, but the node doesn't > specify all properties needed by the driver (which is not a DT > error per se). For such a hub no onboard_hub platform device is > created. However the USB portion of the onboard hub driver still > probes and uses _find_onboard_hub() to find the platform device > that corresponds to the hub. If the DT node of the hub doesn't > have an associated platform device the function looks for a > "peer-hub" node (to get the platform device from there), if > that doesn't exist either it logs an error and returns -EINVAL. > > The absence of a platform device is expected in some > configurations, so drop the error log and fail silently with > -ENODEV. > > Fixes: 8bc063641ceb ("usb: misc: Add onboard_usb_hub driver") > Signed-off-by: Matthias Kaehlcke <mka@chromium.org> > --- > > Changes in v2: > - patch added to the series > > drivers/usb/misc/onboard_usb_hub.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-)
<formletter>
This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.
</formletter>
| |